Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the testtimestamp_add_interval_months #3337

Merged
merged 2 commits into from
Sep 2, 2022

Conversation

HaoYang670
Copy link
Contributor

Signed-off-by: remzi 13716567376yh@gmail.com

Which issue does this PR close?

Closes #3321 .

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

Signed-off-by: remzi <13716567376yh@gmail.com>
@github-actions github-actions bot added the core Core DataFusion crate label Sep 2, 2022
Signed-off-by: remzi <13716567376yh@gmail.com>
Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @HaoYang670

@codecov-commenter
Copy link

Codecov Report

Merging #3337 (92e3c57) into master (dadd2dc) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #3337   +/-   ##
=======================================
  Coverage   85.83%   85.84%           
=======================================
  Files         294      294           
  Lines       53752    53767   +15     
=======================================
+ Hits        46137    46154   +17     
+ Misses       7615     7613    -2     
Impacted Files Coverage Δ
datafusion/core/tests/sql/timestamp.rs 99.66% <100.00%> (+<0.01%) ⬆️
datafusion/expr/src/logical_plan/plan.rs 78.39% <0.00%> (+0.16%) ⬆️
datafusion/core/src/physical_plan/metrics/value.rs 87.43% <0.00%> (+0.50%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@andygrove andygrove merged commit 8b2fd22 into apache:master Sep 2, 2022
@ursabot
Copy link

ursabot commented Sep 2, 2022

Benchmark runs are scheduled for baseline = a5d6ae4 and contender = 8b2fd22. 8b2fd22 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@HaoYang670 HaoYang670 deleted the 3321_fix_test_failure branch September 2, 2022 23:44
@alamb
Copy link
Contributor

alamb commented Sep 4, 2022

Thank you @HaoYang670

kmitchener pushed a commit to kmitchener/arrow-datafusion that referenced this pull request Sep 4, 2022
* update both year and month

Signed-off-by: remzi <13716567376yh@gmail.com>

* fmt

Signed-off-by: remzi <13716567376yh@gmail.com>

Signed-off-by: remzi <13716567376yh@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test case timestamp_add_interval_months failed on master branch
5 participants