Make ObjectStoreProvider fallible (return Result rather than Option)
#3584
Conversation
tustvold
force-pushed
the
fallible-object-store-provider
branch
from
0687700 to
067a25c
Compare
alamb
changed the title
Option rather than None)
alamb
changed the title
Option rather than None)Result rather than Option)
There was a problem hiding this comment.
cc @yahoNanJing and @thinkharderdev for the next ballista upgrade
|
Thanks @tustvold |
Codecov Report
@@ Coverage Diff @@
## master #3584 +/- ##
==========================================
- Coverage 86.03% 86.02% -0.01%
==========================================
Files 300 300
Lines 56253 56250 -3
==========================================
- Hits 48395 48390 -5
- Misses 7858 7860 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Benchmark runs are scheduled for baseline = a080c03 and contender = be6ad1c. be6ad1c is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
| /// Return the key and object store | ||
| fn get_by_url(&self, url: &Url) -> Option<Arc<dyn ObjectStore>>; | ||
| /// Return an ObjectStore for the provided url based on its scheme and authority | ||
| fn get_by_url(&self, url: &Url) -> Result<Arc<dyn ObjectStore>>; |
There was a problem hiding this comment.
Better to change it to be
Result<Option<Arc<dyn ObjectStore>>>
|
Thanks @alamb for this info. I think better to change the return type to be |
|
Follow on PR and discussion for |
Which issue does this PR close?
re #3424
Rationale for this change
#3540 (comment)
What changes are included in this PR?
Makes
ObjectStoreProvider::get_by_urlfallible and clarifies some docsAre there any user-facing changes?