Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor code about subquery_alias and expr-alias. #4451

Merged
merged 5 commits into from
Dec 5, 2022
Merged

refactor code about subquery_alias and expr-alias. #4451

merged 5 commits into from
Dec 5, 2022

Conversation

jackwener
Copy link
Member

@jackwener jackwener commented Dec 1, 2022 •
edited
Loading

Which issue does this PR close?

re #4483

When I was in the process of investigating the reasons for duplicate Projects and duplicate aliases, I find the code of create subquery_alias or expr-alias use multiple method.

After refactor it, we can easily find all code of create alias

Rationale for this change

refactor code about subquery_alias and expr-alias.

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added logical-expr Logical plan and expressions optimizer Optimizer rules sql SQL Planner labels Dec 1, 2022
@jackwener jackwener changed the title minor: remove redundant option in PlanBuilder project_with_alias. refactor: cleanup code of with_alias. Dec 1, 2022
@jackwener jackwener changed the title refactor: cleanup code of with_alias. refactor code about with_alias. Dec 1, 2022
@jackwener
remove project_with_alias.
ed86d58 
refactor: cleanup code of `subqueryAlias` and `expr-alias`.
@jackwener
separate project and subquery_alias
c91cba7
@jackwener jackwener changed the title refactor code about with_alias. refactor code about subquery_alias and expr-alias. Dec 2, 2022
@github-actions github-actions bot added the core Core DataFusion crate label Dec 2, 2022
@jackwener
Copy link
Member Author

😆After this refactor, I have find reason of #4483 and other.
Wait for this merge, I will new PR to fix them

@jackwener jackwener mentioned this pull request Dec 2, 2022
Merged
alamb
alamb approved these changes Dec 2, 2022
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like the approach of consolidating how to make aliases . Big 👍 from me -- thank you @jackwener

cc @avantgardnerio and @andygrove

datafusion/proto/src/logical_plan.rs
)?
.build()

let new_proj = project(input, expr)?;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well that is certainly much nicer

@alamb alamb added the api change Changes the API exposed to users of the crate label Dec 2, 2022
@alamb alamb merged commit 44c20ef into apache:master Dec 5, 2022
@ursabot
Copy link

ursabot commented Dec 5, 2022

Benchmark runs are scheduled for baseline = 394c5ee and contender = 44c20ef. 44c20ef is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@jackwener jackwener deleted the minor branch December 15, 2022 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alamb alamb alamb approved these changes

Assignees
No one assigned
Labels
api change Changes the API exposed to users of the crate core Core DataFusion crate logical-expr Logical plan and expressions optimizer Optimizer rules sql SQL Planner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jackwener @ursabot @alamb