Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ObjectStore from FileStream (#4533) #4601

Merged
merged 2 commits into from
Dec 14, 2022
Merged

Remove ObjectStore from FileStream (#4533) #4601

merged 2 commits into from
Dec 14, 2022

Conversation

tustvold
Copy link
Contributor

@tustvold tustvold commented Dec 13, 2022 •
edited
Loading

Which issue does this PR close?

Closes #4533

Rationale for this change

Reduces the coupling between ParquetExec and ObjectStore

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@tustvold tustvold added the api change Changes the API exposed to users of the crate label Dec 13, 2022
@tustvold tustvold mentioned this pull request Dec 13, 2022
Closed
@github-actions github-actions bot added the core Core DataFusion crate label Dec 13, 2022
@tustvold tustvold marked this pull request as ready for review December 13, 2022 20:28
alamb
alamb approved these changes Dec 13, 2022
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me -- is the rationale that any opener that needs a object_store reference should obtain one as part of construction (rather than requiring it on the trait)?

@tustvold
Copy link
Contributor Author

tustvold commented Dec 13, 2022 •
edited
Loading

the rationale that any opener that needs a object_store reference should obtain one as part of construction (rather than requiring it on the trait)?

The rationale is that some users are not using ObjectStore at all, and are using ParquetFileReaderFactory to provide a custom AsyncFileReader to the parquet crate's async reader. The FileStream plumbing, however, still required an ObjectStore necessitating a dummy object to be propagated through only to be ignored.

@Cheappie
Copy link
Contributor

LGTM

@tustvold
Copy link
Contributor Author

I plan to merge this this afternoon, unless I hear any objections

@tustvold tustvold merged commit 84d3ae8 into apache:master Dec 14, 2022
@ursabot
Copy link

ursabot commented Dec 14, 2022

Benchmark runs are scheduled for baseline = a5cf577 and contender = 84d3ae8. 84d3ae8 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alamb alamb alamb approved these changes

Assignees
No one assigned
Labels
api change Changes the API exposed to users of the crate core Core DataFusion crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FileStream requires fake ObjectStore when ParquetFileReaderFactory is used
4 participants
@tustvold @Cheappie @ursabot @alamb