Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Visit subqueries in Expr::Alias #4900

Merged
merged 1 commit into from
Jan 14, 2023
Merged

fix: Visit subqueries in Expr::Alias #4900

merged 1 commit into from
Jan 14, 2023

Conversation

askoa
Copy link
Contributor

@askoa askoa commented Jan 13, 2023

Which issue does this PR close?

Closes #4898

Rationale for this change

See issue description.

Are these changes tested?

Yes. A new test is included to test the changes.

Are there any user-facing changes?

The users who enable tracing of LogicalPlan might see additional subqueries in the logs.

@github-actions github-actions bot added the logical-expr Logical plan and expressions label Jan 13, 2023
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks @askoa

I wonder if this would be easier to implement if we had some sort of function / visitor that walked a LogicalPlan and visited all expressions as I was discussing with @avantgardnerio on #4701 (comment)

I'll see if I can give it a try

@alamb alamb merged commit 42c81be into apache:master Jan 14, 2023
@ursabot
Copy link

ursabot commented Jan 14, 2023

Benchmark runs are scheduled for baseline = dee0dd8 and contender = 42c81be. 42c81be is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@alamb
Copy link
Contributor

alamb commented Jan 14, 2023

BTW here is a follow on proposal to avoid bugs like this in the future: #4906

@askoa
Copy link
Contributor Author

askoa commented Jan 14, 2023

BTW here is a follow on proposal to avoid bugs like this in the future: #4906

Seems like a nice way to consolidate the approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
logical-expr Logical plan and expressions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LogicalPlan traces do not display subqueries for aliased fields
3 participants