Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor: Port information schema tests to sqllogictest #4905

Merged
merged 1 commit into from
Jan 15, 2023
Merged

Minor: Port information schema tests to sqllogictest #4905

merged 1 commit into from
Jan 15, 2023

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Jan 14, 2023

Which issue does this PR close?

Part of #4495

Rationale for this change

.slt tests are faster to run and easier / faster to maintain

What changes are included in this PR?

Port most remaining tests from information_schema.rs (part of sql_integration) to information_schema.slt

Are these changes tested?

all tests

Are there any user-facing changes?

No

@github-actions github-actions bot added core Core DataFusion crate sqllogictest SQL Logic Tests (.slt) labels Jan 14, 2023
alamb
alamb commented Jan 14, 2023
View reviewed changes
datafusion/core/tests/sqllogictests/test_files/information_schema.slt
@@ -152,3 +155,213 @@ query R
SHOW TIMEZONE
----
datafusion.execution.time_zone +00:00


# information_schema_describe_table
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also like the slt tests as it is easier to see what is covered and what is not in this file

jackwener
jackwener approved these changes Jan 15, 2023
View reviewed changes
Copy link
Member

@jackwener jackwener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense to me❤️

jackwener
jackwener reviewed Jan 15, 2023
View reviewed changes
datafusion/core/tests/sqllogictests/test_files/information_schema.slt
Comment on lines +292 to +294
# show_non_existing_variable
# FIXME
# currently we cannot know whether a variable exists, this will output 0 row instead
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep FIXME👍

@alamb alamb merged commit f376270 into apache:master Jan 15, 2023
@ursabot
Copy link

ursabot commented Jan 15, 2023

Benchmark runs are scheduled for baseline = 195eccf and contender = f376270. f376270 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@alamb alamb deleted the alamb/slt_port branch August 8, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackwener jackwener jackwener approved these changes

Assignees
No one assigned
Labels
core Core DataFusion crate sqllogictest SQL Logic Tests (.slt)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alamb @ursabot @jackwener