Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add substrait label to PRs #4915

Merged
merged 1 commit into from
Jan 15, 2023
Merged

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Jan 15, 2023

Which issue does this PR close?

NA

Rationale for this change

I find myself trying to find PRs in need of review -- having label categorization helps me do so

What changes are included in this PR?

label any PR that modifies a file in datafusion/subtrait with the substrait label. Example

https://github.com/apache/arrow-datafusion/pulls?q=is%3Apr+is%3Aopen+label%3Asubstrait

Are these changes tested?

No (I don't know how to test them other than "live")

Are there any user-facing changes?

No, dev process only

@alamb alamb marked this pull request as ready for review January 15, 2023 12:22
Copy link
Member

@jackwener jackwener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job to me, thanks @alamb

@jackwener jackwener merged commit 195eccf into apache:master Jan 15, 2023
@ursabot
Copy link

ursabot commented Jan 15, 2023

Benchmark runs are scheduled for baseline = e2daee9 and contender = 195eccf. 195eccf is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@alamb alamb deleted the alamb/substrait_labels branch January 15, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants