Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support gs:// as GCS schema #4930

Merged
merged 1 commit into from
Jan 17, 2023
Merged

Support gs:// as GCS schema #4930

merged 1 commit into from
Jan 17, 2023

Conversation

jychen7
Copy link
Contributor

@jychen7 jychen7 commented Jan 17, 2023

Which issue does this PR close?

NA

Rationale for this change

It is a minor improvement. From Google Cloud Console, the schema for GCS is gs://
https://cloud.google.com/storage/docs/gsutil#syntax

What changes are included in this PR?

support gs:// same as gcs://

Are these changes tested?

yes, unit test

Are there any user-facing changes?

No

from Google Cloud Console, the schema for GCS is `gs://`

https://cloud.google.com/storage/docs/gsutil#syntax
@tustvold tustvold merged commit 489a555 into apache:master Jan 17, 2023
@ursabot
Copy link

ursabot commented Jan 17, 2023

Benchmark runs are scheduled for baseline = f27912b and contender = 489a555. 489a555 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@jychen7 jychen7 deleted the patch-3 branch January 17, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants