Only add outer filter once when transforming exists/in subquery to join

[ygf11]

Which issue does this PR close?

Closes #4914.

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Yes.

Are there any user-facing changes?

[ygf11]

cc @mingmwang, this may be relative to your work #4366.

[mingmwang]

Looks like the method's comment is out of date. Could you please also fix them in this PR ?

/// # Arguments
///
/// * subqry - The subquery portion of the `where exists` (select * from orders)
/// * negated - True if the subquery is a `where not exists`
/// * filter_input - The non-subquery portion (from customers)
/// * outer_exprs - Any additional parts to the `where` expression (and c.x = y)
fn optimize_exists(
    query_info: &SubqueryInfo,
    outer_input: &LogicalPlan,
    outer_other_exprs: &[Expr],
)

[mingmwang]

cc @mingmwang, this may be relative to your work #4366.

This PR didn't addressed #4366. I know where the issue is. In this PR, you can just focus on fixing the duplicated Filters bug.

[ygf11]

Looks like the method's comment is out of date. Could you please also fix them in this PR ?

Fixed.

[avantgardnerio]

LGTM, pending the doc fix.

[alamb]

Thanks @avantgardnerio and @ygf11

[ursabot]

Benchmark runs are scheduled for baseline = 22d106a and contender = e566bfc. e566bfc is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java