Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] fix explain csv/json/avro exec can not see metrics bug #5018

Merged
merged 1 commit into from
Jan 24, 2023

Conversation

xiaoyong-z
Copy link
Contributor

@xiaoyong-z xiaoyong-z commented Jan 21, 2023

When we executing explain analyze select * from tablexxx, csv/json/avro exev metrics is empty.
This bug is introduced by not implementing metrics traits in csv/json/avro.

Signed-off-by: xyz a997647204@gmail.com

Which issue does this PR close?

Closes #5014

Rationale for this change

Before
image
After
image

What changes are included in this PR?

implementing metrics traits in csv/json/avro, add csv metrics unit test

Are these changes tested?

yes

Are there any user-facing changes?

User can see metrics in csv exec

When we executing explain analyze select * from tablexxx, csv/json/avro exev
metrics is empty.
This bug is introduced by not implementing metrics traits in csv/json/avro.

Signed-off-by: xyz <a997647204@gmail.com>
@github-actions github-actions bot added the core Core DataFusion crate label Jan 21, 2023
Comment on lines +692 to +699
match metrics.sum_by_name(metric_name) {
Some(v) => v.as_usize(),
_ => {
panic!(
"Expected metric not found. Looking for '{metric_name}' in\n\n{metrics:#?}"
);
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use Option .ok_or()?

Copy link
Member

@jackwener jackwener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, looks great to me

@alamb alamb merged commit 13dfdd6 into apache:master Jan 24, 2023
@ursabot
Copy link

ursabot commented Jan 24, 2023

Benchmark runs are scheduled for baseline = 0820eb9 and contender = 13dfdd6. 13dfdd6 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

explain analyze can not see csvexec execution time metrics
4 participants