Minor: Move some aggregate error tests to sqllogictests #5055
Conversation
github-actions
bot
added
core
| SELECT approx_percentile_cont_with_weight(c3, c2, c1) FROM aggregate_test_100 | ||
|
|
||
|
|
||
| # csv_query_approx_percentile_cont_with_weight |
There was a problem hiding this comment.
And it also seems that each of these 3 error messages should end with dot, though sqllogictests completely ignores actual error message - even
statement error just some random text here
SELECT approx_percentile_cont_with_weight(c1, c2, 0.95) FROM aggregate_test_100
counts as passed test 🤔
There was a problem hiding this comment.
Good call with duplicated block. Thank you 🙏
As for the error messages, I am not sure what you mean by "though sqllogictests completely ignores actual error message - even". Can you please tell me what you did to observe this behavior?
I tried changing the expected error message like this
diff --git a/datafusion/core/tests/sqllogictests/test_files/aggregate.slt b/datafusion/core/tests/sqllogictests/test_files/aggregate.slt
index 3b527dcd8..6931018da 100644
--- a/datafusion/core/tests/sqllogictests/test_files/aggregate.slt
+++ b/datafusion/core/tests/sqllogictests/test_files/aggregate.slt
@@ -56,7 +56,7 @@ SELECT approx_percentile_cont_with_weight(c3, c2, c1) FROM aggregate_test_100
# csv_query_approx_percentile_cont_with_weight
-statement error Error during planning: The function ApproxPercentileContWithWeight does not support inputs of type Utf8.
+statement error some random text
SELECT approx_percentile_cont_with_weight(c1, c2, 0.95) FROM aggregate_test_100
statement error Error during planning: The weight argument for ApproxPercentileContWithWeight does not support inputs of type Utf8And then test failed, as I expected:
cargo test --test sqllogictests
....
STORED AS CSV
WITH HEADER ROW
LOCATION '../../testing/data/csv/aggregate_test_100.csv'"
[aggregate.slt] Running query: "SELECT approx_distinct(c9) count_c9, approx_distinct(cast(c9 as varchar)) count_c9_str FROM aggregate_test_100"
[aggregate.slt] Running query: "SELECT approx_percentile_cont_with_weight(c1, c2, 0.95) FROM aggregate_test_100"
[aggregate.slt] Running query: "SELECT approx_percentile_cont_with_weight(c3, c1, 0.95) FROM aggregate_test_100"
[aggregate.slt] Running query: "SELECT approx_percentile_cont_with_weight(c3, c2, c1) FROM aggregate_test_100"
[aggregate.slt] Running query: "SELECT approx_percentile_cont_with_weight(c1, c2, 0.95) FROM aggregate_test_100"
Error: statement is expected to fail with error:
some random text
but got error:
DataFusion error: Error during planning: The function ApproxPercentileContWithWeight does not support inputs of type Utf8.
[SQL] SELECT approx_percentile_cont_with_weight(c1, c2, 0.95) FROM aggregate_test_100
at tests/sqllogictests/test_files/aggregate.slt:59
error: test failed, to rerun pass `-p datafusion --test sqllogictests`🤔
There was a problem hiding this comment.
Sorry, I should have checked this more careful - it was unsaved version of file.
Now I see that it's ok if expected result is leftmost substring of SQL execution result, so it perfectly explains why missing dot in the end of string doesn't affect test results.
There was a problem hiding this comment.
Thank you for double checking @korowa
|
Benchmark runs are scheduled for baseline = a4ebd39 and contender = be45868. be45868 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
part of #4495
Rationale for this change
We are slowly moving tests to the easier to use / faster to run sqllogictest framework
What changes are included in this PR?
port some tests
Are these changes tested?
Yes
Are there any user-facing changes?
No