[sqllogictests] Port orderby.rs to sqllogictests #5062
Conversation
github-actions
bot
added
core
| @@ -0,0 +1,11 @@ | |||
| 0,0,true | |||
There was a problem hiding this comment.
I captured this data by copying the result of running the code in https://github.com/apache/arrow-datafusion/blob/4a33f2708fe8e30f5f9b062a097fc6155f2db2ce/datafusion/core/tests/sql/partitioned_csv.rs#L47-L73
I think it is easier to understand what is going on if the files are checked in rather than auto generated
datafusion/core/tests/sql/order.rs
Outdated
| let filename = "tests/parquet/data/repeat_much.snappy.parquet"; | ||
|
|
||
| ctx.register_parquet("rep", filename, ParquetReadOptions::default()) | ||
| .await?; | ||
| let sql = "select a from rep order by a"; |
There was a problem hiding this comment.
Should this test be moved to .slt as well?
There was a problem hiding this comment.
Yes. I am not sure how I missed this . Thank you for the catch. It appears to have a pretty massive output that is not easy to replicate in slt, so I will leave it in rust for now.
Co-authored-by: Yevhenii Melnyk <melnyk.yevhenii@gmail.com>
…usion into alamb/port_order_tests
|
Benchmark runs are scheduled for baseline = 556fffb and contender = d588b47. d588b47 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Part of #4495
Rationale for this change
I am about to write tests for #4854 and wanted to use sqllogictests so I figured I would start by porting the existing orderby tests to sqllogictests
What changes are included in this PR?
sqllogictestAre these changes tested?
Yes
Are there any user-facing changes?
No