Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add null-equals-null join support #5085

Merged
merged 1 commit into from
Jan 27, 2023

Conversation

nseekhao
Copy link
Contributor

Which issue does this PR close?

Closes #5084

Rationale for this change

Support for null-equals-null joins as described in #5084.

What changes are included in this PR?

  • Support null-equals-null joins in both producer and consumer
  • Support for accepting ScalarValue::UInt8 in the producer. (Encoded as i32 since Substrait does not support unsigned integers)

Are these changes tested?

Yes

Are there any user-facing changes?

No

@andygrove andygrove merged commit ad3cc24 into apache:master Jan 27, 2023
@ursabot
Copy link

ursabot commented Jan 27, 2023

Benchmark runs are scheduled for baseline = a780a0b and contender = ad3cc24. ad3cc24 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add null-equals-null JOIN support in Substrait producer/consumer
3 participants