Use arrow eq kernels in CaseWhen expression evaluation #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dandandan
changed the title
Codecov Report
@@ Coverage Diff @@
## master #52 +/- ##
==========================================
- Coverage 76.24% 76.24% -0.01%
==========================================
Files 134 134
Lines 23051 23052 +1
==========================================
Hits 17576 17576
- Misses 5475 5476 +1
Continue to review full report at Codecov.
|
andygrove
approved these changes
Apr 25, 2021
jorgecarleitao
approved these changes
Apr 25, 2021
There was a problem hiding this comment.
Yap, simpler and likely more efficient 👍
Thanks a lot, @Dandandan !
houqp
added
ballista
datafusion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #51 .
Rationale for this change
Arro kernels are implemented and tested and should be used when available.
Use more of arrows kernels to benefit more from arrow performance / potential future perf improvements.
What changes are included in this PR?
Use more of arrows kernels to benefit more from arrow speed / potential improvements.
Are there any user-facing changes?
No