Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update sqllogictest requirement from 0.11.1 to 0.12.0 #5237 #5244

Merged
merged 3 commits into from
Feb 11, 2023
Merged

Update sqllogictest requirement from 0.11.1 to 0.12.0 #5237 #5244

merged 3 commits into from
Feb 11, 2023

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Feb 10, 2023

Which issue does this PR close?

Closes #5237

Rationale for this change

Keep up with upstream libraries (thanks @xxchan !)

What changes are included in this PR?

  1. Update version from dependabot Update sqllogictest requirement from 0.11.1 to 0.12.0 #5237
  2. Update driver logic due to sqllogictest's API change

Are these changes tested?

in CI

Are there any user-facing changes?

No

dependabot bot and others added 3 commits February 10, 2023 09:08
@dependabot
Update sqllogictest requirement from 0.11.1 to 0.12.0
a044e28 
Updates the requirements on [sqllogictest](https://github.com/risinglightdb/sqllogictest-rs) to permit the latest version.
- [Release notes](https://github.com/risinglightdb/sqllogictest-rs/releases)
- [Changelog](https://github.com/risinglightdb/sqllogictest-rs/blob/main/CHANGELOG.md)
- [Commits](risinglightdb/sqllogictest-rs@v0.11.1...v0.12.0)

---
updated-dependencies:
- dependency-name: sqllogictest
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@alamb
Merge remote-tracking branch 'apache/master' into dependabot/cargo/ma…
644e380 
…ster/sqllogictest-0.12.0
@alamb
fmt
1e2940b
@alamb alamb added development-process Related to development process of DataFusion auto-dependencies labels Feb 10, 2023
@github-actions github-actions bot added core Core DataFusion crate sqllogictest SQL Logic Tests (.slt) and removed development-process Related to development process of DataFusion labels Feb 10, 2023
alamb
alamb commented Feb 10, 2023
View reviewed changes
datafusion/core/tests/sqllogictests/src/output.rs

use sqllogictest::{DBOutput, DefaultColumnType};

pub type DFColumnType = DefaultColumnType;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DBOutput is now generic to support a custom column type description.

cc @melgenek as I think you were discussing this on a previous PR

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, sqllogictest was updated.

The update in this pr doesn't:

  • validate types by default. By default, any types are successful as long as it can be parsed. Validation can be enabled with runner.with_column_validator(strict_column_validator);
  • --complete doesn't fill in the expected types. I need to create another pr in sqllogictest-rs.

Anyway, I was going to work on #4499 this weekend. If you give me a couple of days, I'll create a pr with type validation.

@alamb alamb mentioned this pull request Feb 10, 2023
Closed
melgenek
melgenek approved these changes Feb 10, 2023
View reviewed changes
datafusion/core/tests/sqllogictests/src/output.rs

use sqllogictest::{DBOutput, DefaultColumnType};

pub type DFColumnType = DefaultColumnType;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, sqllogictest was updated.

The update in this pr doesn't:

  • validate types by default. By default, any types are successful as long as it can be parsed. Validation can be enabled with runner.with_column_validator(strict_column_validator);
  • --complete doesn't fill in the expected types. I need to create another pr in sqllogictest-rs.

Anyway, I was going to work on #4499 this weekend. If you give me a couple of days, I'll create a pr with type validation.

@alamb
Copy link
Contributor Author

alamb commented Feb 10, 2023

Anyway, I was going to work on #4499 this weekend. If you give me a couple of days, I'll create a pr with type validation.

That is great news -- thank you so much @melgenek !

@alamb alamb merged commit 8bc035b into apache:master Feb 11, 2023
@ursabot
Copy link

ursabot commented Feb 11, 2023

Benchmark runs are scheduled for baseline = eda875b and contender = 8bc035b. 8bc035b is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

comphead pushed a commit to comphead/arrow-datafusion that referenced this pull request Feb 11, 2023
@alamb @dependabot @comphead
Update sqllogictest requirement from 0.11.1 to 0.12.0 apache#5237 (ap…
2bd050c 
…ache#5244)

* Update sqllogictest requirement from 0.11.1 to 0.12.0

Updates the requirements on [sqllogictest](https://github.com/risinglightdb/sqllogictest-rs) to permit the latest version.
- [Release notes](https://github.com/risinglightdb/sqllogictest-rs/releases)
- [Changelog](https://github.com/risinglightdb/sqllogictest-rs/blob/main/CHANGELOG.md)
- [Commits](risinglightdb/sqllogictest-rs@v0.11.1...v0.12.0)

---
updated-dependencies:
- dependency-name: sqllogictest
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

* fmt

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@alamb alamb deleted the alamb/update_sqllogictest branch July 26, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melgenek melgenek melgenek approved these changes

Assignees
No one assigned
Labels
auto-dependencies core Core DataFusion crate sqllogictest SQL Logic Tests (.slt)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alamb @ursabot @melgenek