Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing protobuf serialisation functionality GetIndexedFieldExpr. #5324

Merged
merged 1 commit into from
Feb 17, 2023
Merged

Add missing protobuf serialisation functionality GetIndexedFieldExpr. #5324

merged 1 commit into from
Feb 17, 2023

Conversation

ahmedriza
Copy link
Contributor

This is required in order for ballista to serialise the indexing expressions for nested lists. Otherwise, ballista cannot execute any SQL that contains indexing expressions.

Which issue does this PR close?

Closes #5323

Rationale for this change

Add missing protobuf serialisation for GetIndexedFieldExpr that is required when running queries that index nested structures.

What changes are included in this PR?

Add protobuf serialisation for GetIndexedFieldExpr and a unit test.

Are these changes tested?

Yes

Are there any user-facing changes?

No

@ahmedriza
Add missing protobuf serialisation functionality GetIndexedFieldExpr.
aa3982c 
This is required in order for `ballista` to serialise the indexing
expressions for nested lists. Otherwise, `ballista` cannot execute
any SQL that contains indexing expressions.
@ahmedriza ahmedriza mentioned this pull request Feb 17, 2023
Closed
alamb
alamb approved these changes Feb 17, 2023
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a great addition to me -- thank you @ahmedriza

@alamb alamb merged commit c5108ae into apache:main Feb 17, 2023
@alamb
Copy link
Contributor

alamb commented Feb 17, 2023

I merged this soon as I don't think it is controversial. I am happy to make changes or back it out if any maintainer feels differently

@ursabot
Copy link

ursabot commented Feb 17, 2023

Benchmark runs are scheduled for baseline = d6d9c6f and contender = c5108ae. c5108ae is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@ahmedriza ahmedriza deleted the get_indexed_proto branch February 17, 2023 21:01
jiangzhx pushed a commit to jiangzhx/arrow-datafusion that referenced this pull request Feb 24, 2023
@ahmedriza @jiangzhx
Add missing protobuf serialisation functionality GetIndexedFieldExpr. (…
013ce19 
…apache#5324)

This is required in order for `ballista` to serialise the indexing
expressions for nested lists. Otherwise, `ballista` cannot execute
any SQL that contains indexing expressions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alamb alamb alamb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Protobuf serialisation is missing for GetIndexedFieldExpr
3 participants
@ahmedriza @alamb @ursabot