Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor: add tests for subquery to join #5363

Merged
merged 3 commits into from
Feb 25, 2023
Merged

Minor: add tests for subquery to join #5363

merged 3 commits into from
Feb 25, 2023

Conversation

ygf11
Copy link
Contributor

@ygf11 ygf11 commented Feb 22, 2023

Which issue does this PR close?

Closes #.

Add some special test cases that outer and subquery table are same table.

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added core Core DataFusion crate optimizer Optimizer rules labels Feb 22, 2023
@ygf11 ygf11 marked this pull request as ready for review February 22, 2023 07:45
jackwener
jackwener approved these changes Feb 23, 2023
View reviewed changes
Copy link
Member

@jackwener jackwener left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @mingmwang

jackwener
jackwener reviewed Feb 23, 2023
View reviewed changes
datafusion/core/tests/sql/subqueries.rs Outdated
for repartition_joins in test_repartition_joins {
let ctx = create_join_context("t1_id", "t2_id", repartition_joins)?;

// this query will not be rewritten to join
Copy link
Member

@jackwener jackwener Feb 23, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better that add the reason into comment.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the comment.

@alamb alamb merged commit 248d6fc into apache:main Feb 25, 2023
@ursabot
Copy link

ursabot commented Feb 25, 2023

Benchmark runs are scheduled for baseline = 85ed386 and contender = 248d6fc. 248d6fc is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@ygf11 ygf11 deleted the subquery-minor branch March 15, 2023 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackwener jackwener jackwener approved these changes

@yjshen yjshen yjshen approved these changes

@liukun4515 liukun4515 Awaiting requested review from liukun4515

@alamb alamb Awaiting requested review from alamb

Assignees
No one assigned
Labels
core Core DataFusion crate optimizer Optimizer rules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ygf11 @ursabot @yjshen @jackwener @alamb