feat: extensions_options macro
#5442
Conversation
crepererum
force-pushed
the
crepererum/extensions_options_macro
branch
from
a175acf
to
3ba4d39
Compare
|
The issue with prog macros (which I think is what you mean with "attribute macros") is: they are slower, more complicated to write & test, and you ideally have a trait just for the prog macro because they are compiled just to check/document the downstream and you wanna avoid that for costly crates. If you meant "can you just use a macro syntax for defaults"? Ahh, maybe. If there's strong desire to do that, I can try (although I'm not sure if traditional macros can match on macro-like attributes). |
Agree, I tried one recently and it does take me lots of time to debug 😢
As long as the current implementation works fine and does not have ambiguous grammar, we can keep using it. And to me it's straitforward 👍 |
There was a problem hiding this comment.
Other than the location of the test I think this one is ready to go -- thank you @crepererum
For anyone following along, the config was added to IOx in https://github.com/influxdata/influxdb_iox/pull/7020
crepererum
force-pushed
the
crepererum/extensions_options_macro
branch
from
3ba4d39
to
e6ae53e
Compare
There was a problem hiding this comment.
Thank you @crepererum -- this is really nice. Thank you @waynexia for the review
| fn main() { | ||
| // set up config struct and register extension | ||
| let mut config = ConfigOptions::default(); | ||
| config.extensions.insert(MyConfig::default()); |
| @@ -634,3 +634,129 @@ trait Visit { | |||
|
|
|||
| fn none(&mut self, key: &str, description: &'static str); | |||
| } | |||
|
|
|||
| /// Convenience macro to create [`ExtensionsOptions`]. | |||
|
Benchmark runs are scheduled for baseline = ac618f0 and contender = e985207. e985207 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
-
Rationale for this change
I was implementing
ExtensionsOptionsin InfluxDB IOx and it was quite cumbersome, since you need to be very careful to keep all theset/entriesmethods in sync with the structure definition. So I wrote a macro that does a similar magic than the DF builtin configs. I would like to upstream this since I think it actually makes config extensions usable.What changes are included in this PR?
A new macro.
Are these changes tested?
Small "does it expand" test.
Are there any user-facing changes?
New macro.