-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add a unit test that cover cast bug. #5443
Conversation
I investigate this bug, but I can't fix it. cc @liukun4515 @mingmwang @alamb @jorgecarleitao . |
This is a great reproducer -- thank you @jackwener |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is good to leave a reference to the ticket this is for 👍
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
It's resolved in arrow-rs apache/arrow-rs#3690 |
Benchmark runs are scheduled for baseline = 17b2f11 and contender = a4b47d8. a4b47d8 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
related #5396
Rationale for this change
This test is minimum reproduce case of a bug in tpcds-q58.
"CAST(Int64(100) AS Decimal128(38, 38))"
It will fail in
and throw "ArrowError(ComputeError("Overflow happened on: 100 * 100000000000000000000000000000000000000"))"
What changes are included in this PR?
Add a unit test reproduce a bug.
Are these changes tested?
Are there any user-facing changes?