Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add std,median result to describe method #5445

Merged
merged 1 commit into from
Mar 2, 2023
Merged

Conversation

jiangzhx
Copy link
Contributor

@jiangzhx jiangzhx commented Mar 2, 2023

Rationale for this change

add std,median result to describe method to keep same with polars.

What changes are included in this PR?

calc std,median result for all columns , only include column datatype is is_numeric

describe id bool_col tinyint_col smallint_col int_col bigint_col float_col double_col date_string_col string_col timestamp_col
count 8.0 8 8.0 8.0 8.0 8.0 8.0 8.0 8 8 8
null_count 8.0 8 8.0 8.0 8.0 8.0 8.0 8.0 8 8 8
mean 3.5 null 0.5 0.5 0.5 5.0 0.550000011920929 5.05 null null null
std 2.4494897427831783 null 0.5345224838248488 0.5345224838248488 0.5345224838248488 5.3452248382484875 0.5879747449513427 5.398677086630973 null null null
min 0.0 null 0.0 0.0 0.0 0.0 0.0 0.0 null null 2009-01-01T00:00:00
max 7.0 null 1.0 1.0 1.0 10.0 1.100000023841858 10.1 null null 2009-04-01T00:01:00
median 3.0 null 0.0 0.0 0.0 5.0 0.550000011920929 5.05 null null null

Are there any user-facing changes?

returned by describe method adds more information。

@github-actions github-actions bot added the core Core DataFusion crate label Mar 2, 2023
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool -- thank you @jiangzhx

I also appreciate that you broke this feature up into several small PRs. Very much appreciated 🙏

@alamb alamb merged commit 49473d6 into apache:main Mar 2, 2023
@alamb
Copy link
Contributor

alamb commented Mar 2, 2023

Related to #4974

@ursabot
Copy link

ursabot commented Mar 2, 2023

Benchmark runs are scheduled for baseline = a95e0ec and contender = 49473d6. 49473d6 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants