Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable hash joins on FixedSizeBinary columns #5461

Merged
merged 1 commit into from
Mar 3, 2023

Conversation

maxburke
Copy link
Contributor

@maxburke maxburke commented Mar 2, 2023

This helps ameliorate the performance issues in #5456 though the correctness issues identified in that issue still exist.

Before:

358946 rows in set. Query took 356.370 seconds.

After:

358946 rows in set. Query took 2.073 seconds.

@alamb
Copy link
Contributor

alamb commented Mar 3, 2023

Thanks @maxburke -- it may be worth looking into to adding tests for FixedSizeBinary this datatype too. It is currenly somewhat inconvenient to do so, but I am hoping to work on #5016 to make it easier to write

@alamb alamb merged commit ac618f0 into apache:main Mar 3, 2023
@ursabot
Copy link

ursabot commented Mar 3, 2023

Benchmark runs are scheduled for baseline = 8de7ea4 and contender = ac618f0. ac618f0 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants