Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compute_decimal_op_dyn_scalar should not cast lhs array to decimal array #5465

Merged
merged 1 commit into from
Mar 4, 2023
Merged

compute_decimal_op_dyn_scalar should not cast lhs array to decimal array #5465

merged 1 commit into from
Mar 4, 2023

Conversation

viirya
Copy link
Member

@viirya viirya commented Mar 3, 2023

Which issue does this PR close?

Closes #5464.

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added the physical-expr Physical Expressions label Mar 3, 2023
alamb
alamb approved these changes Mar 3, 2023
View reviewed changes
datafusion/physical-expr/src/expressions/binary.rs
if let ScalarValue::Decimal128(Some(v_i128), _, _) = $RIGHT {
Ok(Arc::new(paste::expr! {[<$OP _dyn_scalar>]}(ll, v_i128)?))
Ok(Arc::new(paste::expr! {[<$OP _dyn_scalar>]}($LEFT, v_i128)?))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it makes sense to me not to cast the left hand side

In general, now that the dyn kernels are more complete, I wonder if we need the specific decimal macros at all 🤔

@alamb
Copy link
Contributor

alamb commented Mar 3, 2023

Thank you @viirya

@alamb alamb merged commit 132ae42 into apache:main Mar 4, 2023
@ursabot
Copy link

ursabot commented Mar 4, 2023

Benchmark runs are scheduled for baseline = e985207 and contender = 132ae42. 132ae42 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@viirya
Copy link
Member Author

viirya commented Mar 4, 2023

Thanks @alamb

@alamb
Copy link
Contributor

alamb commented Mar 4, 2023

Thanks @alamb

👍 -- I am get somewhat anxious when the PR / merge backlog gets large and so then I try and merge anything that looks ready to keep if from growing bigger 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alamb alamb alamb approved these changes

Assignees
No one assigned
Labels
physical-expr Physical Expressions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

compute_decimal_op_dyn_scalar should not cast lhs array to decimal array
3 participants
@viirya @alamb @ursabot