excluding doctests for mac/win64 platform ,Make them consistent with amd64 #5730
Conversation
jiangzhx
force-pushed
the
excluding_doctests_on_mac_win
branch
from
f810930 to
93df23d
Compare
|
BTW: cargo test(win64) is much slower than amd64 and mac
|
| shell: bash | ||
| run: | | ||
| export PATH=$PATH:$HOME/d/protoc/bin | ||
| cargo test | ||
| cargo test --lib --tests --bins --features avro,jit,scheduler,json,dictionary_expressions |
There was a problem hiding this comment.
I think it is a reasonable idea to run with the same features on mac and windows. Thank you @jiangzhx
|
Can you please explain a little about the rationale for this change (why you made it)? |
I found that cargo test (win64) is much slower than amd64 and mac. if we can make them consistent with amd64, which would make it easier to identify reason . |
|
🤔 interestingly the CI tests did not trigger on this PR, which I noticed when trying to check the timings. I will fix that too and hopefully we can see the effect on this PR |
|
Testing CI with #5759 |
Which issue does this PR close?
excluding doctests for mac/win64 platform ,Make them consistent with amd64.
There is already a standalone doctests on amd64
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?