Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: remove typed_min_max_batch_decimal128 #5809

Merged
merged 2 commits into from
Mar 31, 2023
Merged

Minor: remove typed_min_max_batch_decimal128 #5809

merged 2 commits into from
Mar 31, 2023

Conversation

izveigor
Copy link
Contributor

Which issue does this PR close?

Follow on to apache/arrow-rs#1010

Rationale for this change

This function is not necessary now.

What changes are included in this PR?

Remove the function "remove typed_min_max_batch_decimal128".

Are these changes tested?

Yes

Are there any user-facing changes?

No

@github-actions github-actions bot added the physical-expr Physical Expressions label Mar 31, 2023
Copy link
Contributor

@Dandandan Dandandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup

Copy link
Member

@jackwener jackwener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A great cleanup job. Thanks @izveigor

@jackwener jackwener merged commit df28b01 into apache:main Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
physical-expr Physical Expressions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants