Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: BuiltinScalarFunction::Cbrt #5839

Merged
merged 6 commits into from
Apr 5, 2023
Merged

feat: BuiltinScalarFunction::Cbrt #5839

merged 6 commits into from
Apr 5, 2023

Conversation

izveigor
Copy link
Contributor

@izveigor izveigor commented Apr 3, 2023

Which issue does this PR close?

Part of #5838

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Yes

Are there any user-facing changes?

Yes

@github-actions github-actions bot added core Core DataFusion crate logical-expr Logical plan and expressions physical-expr Changes to the physical-expr crates labels Apr 3, 2023
yjshen
yjshen reviewed Apr 3, 2023
View reviewed changes
Copy link
Member

@yjshen yjshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @izveigor for the contribution! Could you please also update the documentation in both docs/source/user-guide/expression.md and docs/source/user-guide/sql/scala_functions.md?

alamb
alamb approved these changes Apr 3, 2023
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @izveigor

@alamb
Copy link
Contributor

alamb commented Apr 5, 2023

Thanks again @izveigor and @yjshen !

@alamb alamb merged commit 8d428c3 into apache:main Apr 5, 2023
@izveigor izveigor mentioned this pull request Apr 5, 2023
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alamb alamb alamb approved these changes

@yjshen yjshen yjshen left review comments

Assignees
No one assigned
Labels
core Core DataFusion crate logical-expr Logical plan and expressions physical-expr Changes to the physical-expr crates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@izveigor @alamb @yjshen