-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moving PipelineFixer above all rules to use ExecutionPlan APIs #5880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…HJ code simplifications
mustafasrepo
reviewed
Apr 6, 2023
mustafasrepo
reviewed
Apr 6, 2023
alamb
approved these changes
Apr 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense to me -- thank you @metesynnada
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #5878.
Rationale for this change
Since some strongly dependent optimizer rules affect each other, rule ordering becomes more important. PipelineFixer (maybe more rules in the future) can change the ExecutionPlan at a level, and the new
ExecutionPlan
can have a different set of flags (maybe ordering, distribution, or more).I suggest making the executor changer rules above the rules that fill the sort, distribution, etc.
If the sources are also sorted, we are looking for keeping the order information without adding additional SortExec. However, current planner results
and, unfortunately, two consecutive
RepartitionExec
removes the order information. To prevent this, SHJ particularly setsbenefits_from_input_partitioning
tofalse
, however, it is ineffective sinceRepartitionExec::RounRobin
is added beforeHashJoin -> SymmetricHashJoin
change.If we move the
Repartition
rule below thePipelineFixer
, we are able to useSymmetricHashJoinExec
'sbenefits_from_input_partitioning
API effectively.What changes are included in this PR?
Optimizer reorders to use the
benefits_from_input_partitioning
API. If we call PipelineFixer above (almost) everything, we can leverage the changed executor APIs in the optimizer.Are these changes tested?
Yes.
Are there any user-facing changes?
No.