Improve main api doc page, move avro_to_arrow to datasource
#6564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core
alamb
commented
Jun 6, 2023
| @@ -412,7 +413,6 @@ pub const DATAFUSION_VERSION: &str = env!("CARGO_PKG_VERSION"); | |||
| extern crate core; | |||
| extern crate sqlparser; | |||
|
|
|||
| pub mod avro_to_arrow; | |||
There was a problem hiding this comment.
Technically this is a breaking API change, but I don't expect it to be a large impact as I think the use of avro_to_arrow is likely small.
If it turns out others are using it more extensively, I think we should contemplate moving it to its own crate (or maybe upstream into arrow-rs)
alamb
force-pushed
the
alamb/clean_up_docs
branch
from
d0f3e63 to
514113b
Compare
|
(I am in parallel working to remove |
alamb
changed the title
avro_to_arrow to datasource
avantgardnerio
approved these changes
Jun 11, 2023
|
Thanks @avantgardnerio ! |
jayzhan211
pushed a commit
to jayzhan211/datafusion
that referenced
this pull request
Jun 12, 2023
…he#6564) * Improve main api doc page * fix doc examples * fmt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Related to #3058
Rationale for this change
The main docs landing page is somewhat messy and inconsistent. I would like this to be better when users try to use DataFusion
What changes are included in this PR?
Clean up docs and move the
avro_to_arrowmodule intodatasourceas it is somewhat specializedAfter changes:
Are these changes tested?
Are there any user-facing changes?