Remove namespace from executors #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #75 +/- ##
=======================================
Coverage 76.35% 76.36%
=======================================
Files 134 134
Lines 23018 23017 -1
=======================================
Hits 17576 17576
+ Misses 5442 5441 -1
Continue to review full report at Codecov.
|
edrevo
force-pushed
the
remove-unnecessary-namespace
branch
from
33dfcc3 to
5016ea4
Compare
andygrove
approved these changes
Apr 27, 2021
|
@edrevo Please rebase and we can merge this one. Thanks! |
edrevo
force-pushed
the
remove-unnecessary-namespace
branch
from
5016ea4 to
3b64387
Compare
|
done! |
houqp
added
api change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #66.
Are there any user-facing changes?
Yes. The
namespaceCLI option in the ballista executors disappear. This is actually good, since the description of that param was not in sync with the implementation.