sqllogictest: move the creation of the nan_table from Rust to slt #9022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
approved these changes
Jan 27, 2024
| @@ -1383,7 +1383,8 @@ create table test_boolean(c1 boolean) as values (false), (null), (true); | |||
| statement ok | |||
| create table test_int32(c1 int) as values (0), (1), (null), (3); | |||
|
|
|||
| ## Note that test_float has a NaN (which is not possible to create in SQL) so it is registered via rust. | |||
| statement ok | |||
| create table test_float(c1 double) as values (1.0), (null), ('NaN'::double); | |||
There was a problem hiding this comment.
I double checked
❯ select arrow_typeof('NaN'::double), 'NaN'::double;
+---------------------------+-------------+
| arrow_typeof(Utf8("NaN")) | Utf8("NaN") |
+---------------------------+-------------+
| Float64 | NaN |
+---------------------------+-------------+
1 row in set. Query took 0.004 seconds.
👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
Make the implementation of this test simpler and more localized.
What changes are included in this PR?
Move the creation of the nan_table from Rust to slt.
Are these changes tested?
Yes, existing tests.
Are there any user-facing changes?
No