-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow non-nullable schemas to be created #604
Comments
That is a great point...it was this way initially due to the
This is probably your best bet for now, but it would be cheap to add |
Yep -- I actually like a simple pair of |
We commonly use a combination of columns that are non-nullable and nullable. The current default of 'always nullable' from e.g. line 179 here is a little strict.
arrow-nanoarrow/src/nanoarrow/common/schema.c
Lines 175 to 185 in 75ef830
Obviously, we can add a local variant with an added bool which calls this and then, as needed, follows up with
But can you see a way to more cleanly allow this? There are a few spots that condition / undo but they seem like lower-level entry points. If I am missing something really obvious don't be shy and call me out 😀
The text was updated successfully, but these errors were encountered: