Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Record Reader Incomplete State #1020

Closed
tustvold opened this issue Dec 10, 2021 · 0 comments · Fixed by #1021
Closed

Record Reader Incomplete State #1020

tustvold opened this issue Dec 10, 2021 · 0 comments · Fixed by #1021
Labels
enhancement Any new improvement worthy of a entry in the changelog

Comments

@tustvold
Copy link
Contributor

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

Whilst working on #171 I found the logic in parquet::arrow::RecordReader very difficult to follow. This mainly stems from the fact it has a state where it is part way through "consuming" a record, and state is mutated in multiple places.

Describe the solution you'd like

It is possible to simplify the logic, at the cost of potentially scanning repetition levels multiple times. In practice this is already done as consequence of calling RecordReader::reset. This combined with the overheads of splitting the buffers makes me suspect the performance difference will be negligible.

Describe alternatives you've considered

The existing logic is not wrong, and so could remain unchanged.

@tustvold tustvold added the enhancement Any new improvement worthy of a entry in the changelog label Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant