Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove broken memory-tracking crate feature #1171

Closed
jhorstmann opened this issue Jan 14, 2022 · 1 comment · Fixed by #1222
Closed

Remove broken memory-tracking crate feature #1171

jhorstmann opened this issue Jan 14, 2022 · 1 comment · Fixed by #1222
Labels

Comments

@jhorstmann
Copy link
Contributor

Describe the bug

The non-default memory-check feature fails to compile (probably at least since 2021-04, that was the last time alloc/mod.rs was changed).

To Reproduce

$ cargo test --features memory-check
error[E0432]: unresolved import `crate::memory`
  --> arrow/src/zz_memory_check.rs:24:16
   |
24 |     use crate::memory::ALLOCATIONS;
   |                ^^^^^^ could not find `memory` in the crate root

Expected behavior

Since it seems to be unused, it is probably fine to remove the feature and the static ALLOCATIONS counter. If we decide to keep the feature, I would suggest to also move the increments/decrements of that counter behind the feature, as it could cause some contention in heavy multithreaded programs.

Additional context
Add any other context about the problem here.

@jhorstmann jhorstmann added the bug label Jan 14, 2022
@alamb
Copy link
Contributor

alamb commented Jan 14, 2022

I think we should remove it 👍

@alamb alamb changed the title Fix or remove memory-tracking feature Remove broken memory-tracking crate feature Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants