Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parquet Record Tests Fail on Rust 1.58 #1177

Closed
tustvold opened this issue Jan 14, 2022 · 0 comments · Fixed by #1178
Closed

Parquet Record Tests Fail on Rust 1.58 #1177

tustvold opened this issue Jan 14, 2022 · 0 comments · Fixed by #1178
Assignees
Labels
bug development-process Related to development process of arrow-rs

Comments

@tustvold
Copy link
Contributor

Describe the bug

Initially noticed on #1174 but it would appear the formatting changes in Rust 1.58 have altered the formatting of floating point numbers causing the tests to fail

To Reproduce

Run the test_convert_double_to_string test on master, and it will fail with

Left:  1e-15
Right: 0.000000000000001
<Click to see difference>

thread 'record::api::tests::test_convert_double_to_string' panicked at 'assertion failed: `(left == right)`
  left: `"1e-15"`,
 right: `"0.000000000000001"`', parquet/src/record/api.rs:1096:9
stack backtrace:

Expected behavior

Test should not fail

@tustvold tustvold added the bug label Jan 14, 2022
@alamb alamb added the development-process Related to development process of arrow-rs label Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug development-process Related to development process of arrow-rs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants