-
Notifications
You must be signed in to change notification settings - Fork 853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement DecimalArray support in eq_dyn
, neq_dyn
, lt_dyn
, lt_eq_dyn
, gt_dyn
, gt_eq_dyn
#1200
Comments
@alamb Do you begin to do this? |
@liukun4515 I have not started this |
Any more progress? If no, I may find some time working on this. |
I have not made any progress on this sadly |
I will do this when the kernel functions are ready in the datafusion side. |
I think the idea is to
Here is the code in datafusion Needs to brought to https://sourcegraph.com/github.com/apache/arrow-rs/-/blob/arrow/src/compute/kernels/comparison.rs?L7&subtree=true and then also added to |
we can close it. |
Is your feature request related to a problem or challenge? Please describe what you are trying to do.
Rationale make it as easier (more ergonomic) to implement array comparison, both for DataFusion and other users. See rationale in #843
Describe the solution you'd like
The idea would basically be to implement the same thing as @viirya did for timestamp types in #1095 but for
DecimalArrays
That is the following code should not assert and compare the decimal arrays element by element:
Describe alternatives you've considered
For completeness, we could also add
eq_decimal
,neq_decimal
, etc as well, though I personally think focusing on the dyn kernels would be the easiest thing.Additional context
@liukun4515 has added kernels in DataFusion here which could be adapted
https://github.com/apache/arrow-datafusion/blob/master/datafusion/src/physical_plan/expressions/binary.rs#L80-L231
other context:
I am trying to move datafusion over to using the dyn kernels here: apache/datafusion#1475
The text was updated successfully, but these errors were encountered: