New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_column_chunk_metadata_thrift_conversion test bug #1319

Closed

shanisolomon opened this issue Feb 16, 2022 · 0 comments · Fixed by #1320

Labels

bug development-process

Contributor

shanisolomon commented Feb 16, 2022

test_column_chunk_metadata_thrift_conversion doesn't check full thrift conversion. It only checks from_thrift as it comares two thrift objects.

test_column_chunk_metadata_thrift_conversion passing didn't flag to_thrift wasn't altered to assign bloom_filter_offset as part as #1309.

shanisolomon added the bug label

shanisolomon mentioned this issue

fix test bug and ensure that bloom filter metadata is serialized in to_thrift #1320

Merged

alamb added the development-process label

alamb closed this as completed in #1320

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment