We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RecordBatch::validate_new_batch
Describe the bug The function validate_new_batch constains some repetitive code. We could find a way to refactor it. https://github.com/apache/arrow-rs/blob/master/arrow/src/record_batch.rs#L133-L166
validate_new_batch
To Reproduce
Expected behavior Clean and readable code
Additional context Add any other context about the problem here.
The text was updated successfully, but these errors were encountered:
Using Iterator.find or Iterator.any may be a good choice.
Iterator.find
Iterator.any
Sorry, something went wrong.
@alamb Is this refactoring worth to do?
Hi @HaoYang670 -- sorry i am just getting back from a week away. I will check this (and the linked PR out) over the next day or two
Successfully merging a pull request may close this issue.
Describe the bug
The function
validate_new_batch
constains some repetitive code. We could find a way to refactor it.https://github.com/apache/arrow-rs/blob/master/arrow/src/record_batch.rs#L133-L166
To Reproduce
Expected behavior
Clean and readable code
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: