Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark the current substring function as unsafe and rename it. #1541

Closed
HaoYang670 opened this issue Apr 12, 2022 · 1 comment
Closed

Mark the current substring function as unsafe and rename it. #1541

HaoYang670 opened this issue Apr 12, 2022 · 1 comment
Labels
arrow Changes to the arrow crate

Comments

@HaoYang670
Copy link
Contributor

This is an individual task of #1531

  1. The current substring function might return an invalid string array (see The substring kernel panics when chars > U+0x007F #1478 ), so we need to mark it as unsafe.
  2. Rename the function as substring_bytes_unchecked (see Improve doc string for substring kernel #1529 (comment))
@HaoYang670 HaoYang670 added the enhancement Any new improvement worthy of a entry in the changelog label Apr 12, 2022
This was referenced Apr 12, 2022
Open
Closed
@HaoYang670
Copy link
Contributor Author

Close it!

@alamb alamb added arrow Changes to the arrow crate and removed enhancement Any new improvement worthy of a entry in the changelog labels Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arrow Changes to the arrow crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not merge! Rename the substring function and mark it as unsafe HaoYang670/arrow-rs
2 participants
@alamb @HaoYang670