Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dense UnionArray Offsets Are i32 not i8 #1597

Closed
tustvold opened this issue Apr 20, 2022 · 1 comment
Closed

Dense UnionArray Offsets Are i32 not i8 #1597

tustvold opened this issue Apr 20, 2022 · 1 comment
Labels
arrow Changes to the arrow crate question Further information is requested

Comments

@tustvold
Copy link
Contributor

Describe the bug

The specification defines a Dense Union as

Types buffer: A buffer of 8-bit signed integers. Each type in the union has a corresponding type id whose values are found in this buffer. A union with more than 127 possible types can be modeled as a union of unions.

Expected behavior

They are currently represented as i32 when they should be i8
@tustvold tustvold added question Further information is requested bug labels Apr 20, 2022
@tustvold
Copy link
Contributor Author

I got the offsets and types buffers confused 🤦

@alamb alamb added arrow Changes to the arrow crate and removed bug labels Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arrow Changes to the arrow crate question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alamb @tustvold