Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Unit Test Coverage of Parquet -> Arrow Converter #1698

Closed
tustvold opened this issue May 13, 2022 · 0 comments · Fixed by #2528
Closed

Improve Unit Test Coverage of Parquet -> Arrow Converter #1698

tustvold opened this issue May 13, 2022 · 0 comments · Fixed by #2528
Labels
enhancement Any new improvement worthy of a entry in the changelog

Comments

@tustvold
Copy link
Contributor

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

#1682 added new logic for the parquet -> arrow schema conversion, and relied on the existing test coverage in schema.rs to validate this. However, these tests only validate the type conversions, and not the definition/repetition levels. It would be good to add some additional test coverage to cover this

Describe the solution you'd like

Unit tests within the complex.rs module

Additional context

Suggested by @alamb https://github.com/apache/arrow-rs/pull/1682/files/e2f12dedaac3d7cc0ce95cec504ff87e26d6cf4f#r871363997

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant