Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bit_slice should be a method of Bitmap #1728

Closed
HaoYang670 opened this issue May 23, 2022 · 1 comment
Closed

bit_slice should be a method of Bitmap #1728

HaoYang670 opened this issue May 23, 2022 · 1 comment
Labels
enhancement Any new improvement worthy of a entry in the changelog

Comments

@HaoYang670
Copy link
Contributor

Describe the solution you'd like
A clear and concise description of what you want to happen.
https://github.com/apache/arrow-rs/blob/master/arrow/src/buffer/immutable.rs#L201-L210
We should move this method to Bitmap as it is a bitwise operation.
@HaoYang670 HaoYang670 added the enhancement Any new improvement worthy of a entry in the changelog label May 23, 2022
@HaoYang670 HaoYang670 changed the title The bit_slice method should under Bitmap bit_slice should be a method of Bitmap May 23, 2022
@HaoYang670 HaoYang670 mentioned this issue Jun 7, 2022
Closed
@tustvold
Copy link
Contributor

Closed by #3778

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tustvold @HaoYang670