You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem or challenge? Please describe what you are trying to do.
This is a follow-up of #1720.
We have added concatenate by elements support for string array and put it into the new created string kernel.
I suggest we should rename the kernel concatenate_elements.
There are some reasons I thought why concatenate_elements is better than string:
The name of the compute kernel should express what kind of operation will be done on an array, such as cast, aggregate ...
We can support the concatenate_elements operation on binary array, list array and other nested types. So string is not an appropriate name.
I suggest we should rename the kernel concatenate_elements.
If you mean rename arrow/src/compute/kernels/string.rs to arrow/src/compute/kernels/concat_elements.rs I think it is a great idea (and ideally we could do it in the next day or two before we released arrow 15 avoiding a breaking change in a released version)
HaoYang670
changed the title
Rename the string kernel as concatenate_elements
Rename the string kernel to concatenate_elementsMay 26, 2022
Is your feature request related to a problem or challenge? Please describe what you are trying to do.
This is a follow-up of #1720.
We have added
concatenate by elements
support for string array and put it into the new createdstring
kernel.I suggest we should rename the kernel
concatenate_elements
.There are some reasons I thought why
concatenate_elements
is better thanstring
:cast
,aggregate
...concatenate_elements
operation on binary array, list array and other nested types. Sostring
is not an appropriate name.https://github.com/rapidsai/cudf/blob/branch-22.08/cpp/src/lists/combine/concatenate_rows.cu
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.
The text was updated successfully, but these errors were encountered: