Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename the string kernel to concatenate_elements #1747

Closed
HaoYang670 opened this issue May 26, 2022 · 2 comments · Fixed by #1752
Closed

Rename the string kernel to concatenate_elements #1747

HaoYang670 opened this issue May 26, 2022 · 2 comments · Fixed by #1752
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog

Comments

@HaoYang670
Copy link
Contributor

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
This is a follow-up of #1720.
We have added concatenate by elements support for string array and put it into the new created string kernel.
I suggest we should rename the kernel concatenate_elements.

There are some reasons I thought why concatenate_elements is better than string:

  1. The name of the compute kernel should express what kind of operation will be done on an array, such as cast, aggregate ...
  2. We can support the concatenate_elements operation on binary array, list array and other nested types. So string is not an appropriate name.
  3. In cudf (which is based on Arrow c++, and more GPU supported), there are similar kernels and we can refer to their names.: https://github.com/rapidsai/cudf/blob/branch-22.08/cpp/src/lists/combine/concatenate_list_elements.cu
    https://github.com/rapidsai/cudf/blob/branch-22.08/cpp/src/lists/combine/concatenate_rows.cu

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@HaoYang670 HaoYang670 added the enhancement Any new improvement worthy of a entry in the changelog label May 26, 2022
@HaoYang670
Copy link
Contributor Author

cc @alamb @tustvold @viirya. Looking forward to your opinions!

@alamb
Copy link
Contributor

alamb commented May 26, 2022

Hi @HaoYang670

I suggest we should rename the kernel concatenate_elements.

If you mean rename arrow/src/compute/kernels/string.rs to arrow/src/compute/kernels/concat_elements.rs I think it is a great idea (and ideally we could do it in the next day or two before we released arrow 15 avoiding a breaking change in a released version)

@HaoYang670 HaoYang670 changed the title Rename the string kernel as concatenate_elements Rename the string kernel to concatenate_elements May 26, 2022
@alamb alamb added the arrow Changes to the arrow crate label May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants