Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename arrow/benches/string_kernels.rs to arrow/benches/substring_kernels.rs #1786

Closed
HaoYang670 opened this issue Jun 4, 2022 · 1 comment · Fixed by #1805
Closed

Rename arrow/benches/string_kernels.rs to arrow/benches/substring_kernels.rs #1786

HaoYang670 opened this issue Jun 4, 2022 · 1 comment · Fixed by #1805
Labels
development-process Related to development process of arrow-rs enhancement Any new improvement worthy of a entry in the changelog

Comments

@HaoYang670
Copy link
Contributor

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
All benchmarks in string_kernel.rs are related to substring. So we should rename the file substring_kernel.rs
@HaoYang670 HaoYang670 added the enhancement Any new improvement worthy of a entry in the changelog label Jun 4, 2022
@HaoYang670 HaoYang670 changed the title Rename arrow/benches/string_kernels.rs to arrow/benches/substring_kernel.rs Rename arrow/benches/string_kernels.rs to arrow/benches/substring_kernels.rs Jun 7, 2022
@HaoYang670 HaoYang670 mentioned this issue Jun 7, 2022
Merged
@alamb alamb added the development-process Related to development process of arrow-rs label Jun 9, 2022
@alamb
Copy link
Contributor

alamb commented Jun 9, 2022

marked as development process as changed code that was never released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
development-process Related to development process of arrow-rs enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename arrow/benches/string_kernels.rs to arrow/benches/substring_kernels.rs HaoYang670/arrow-rs
2 participants
@alamb @HaoYang670