You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem or challenge? Please describe what you are trying to do.
pub trait PageReader: Iterator<Item = Result<Page>> + Send {
/// Gets the next page in the column chunk associated with this reader.
/// Returns `None` if there are no pages left.
fn get_next_page(&mut self) -> Result<Option<Page>>;
}
change to
pub trait PageReader: Iterator<Item = Result<Page>> + Send {
/// Gets the next page in the column chunk associated with this reader.
/// Returns `None` if there are no pages left.
fn get_next_page(&mut self) -> Result<Option<Page>>;
/// Gets the next page in the column chunk associated with this reader.
/// Returns `None` if there are no pages left.
fn get_next_page_header(&mut self) -> Result<Option<PageHeader>>;
}
i want to add skip_page in PageReader (for page index) need check page header before call skip_page (
can not skip DictionaryPageIndexPage),
but now read header is in get_next_page, so extract it to a new func.
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
put skip_page in get_next_page
Additional context
Add any other context or screenshots about the feature request here.
The text was updated successfully, but these errors were encountered:
I could be missing something, but I was under the impression the intention of the ColumnIndex, as opposed to using page-level statistics, was precisely to avoid needing to read any page data for those being skipped? Is this information not encoded in the PageLocation index or something?
Is your feature request related to a problem or challenge? Please describe what you are trying to do.
change to
i want to add
skip_page
in PageReader (for page index) need check page header before callskip_page
(can not skip
DictionaryPage
IndexPage
),but now read header is in
get_next_page
, so extract it to a new func.Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
put
skip_page
inget_next_page
Additional context
Add any other context or screenshots about the feature request here.
The text was updated successfully, but these errors were encountered: