Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve formatting of logical plans containing subqueries #2059

Closed
andygrove opened this issue Jul 13, 2022 · 2 comments
Closed

Improve formatting of logical plans containing subqueries #2059

andygrove opened this issue Jul 13, 2022 · 2 comments
Assignees
@andygrove

Comments

@andygrove
Copy link
Member

andygrove commented Jul 13, 2022 •
edited
Loading

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
When we implemented subqueries in the logical plan, we did not update the display logic, and the plans are hard to read because the indentation is not correct.

Describe the solution you'd like
Fix the formatting. Here is a proposal:

Projection: #employee_csv.id
  Filter: #employee_csv.state IN (<subquery>)
    Subquery:
      TableScan: employee_csv projection=[state]
    TableScan: employee_csv projection=[id, state]

Describe alternatives you've considered
None

Additional context
None
@andygrove andygrove added the enhancement Any new improvement worthy of a entry in the changelog label Jul 13, 2022
@andygrove andygrove self-assigned this Jul 13, 2022
@andygrove
Copy link
Member Author

oops, wrong repo

@andygrove
Copy link
Member Author

moved to apache/datafusion#2898

@alamb alamb removed the enhancement Any new improvement worthy of a entry in the changelog label Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andygrove andygrove

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alamb @andygrove