Rename weekday
and weekday0
kernels to to num_days_from_monday
and days_since_sunday
#2065
Labels
weekday
and weekday0
kernels to to num_days_from_monday
and days_since_sunday
#2065
Is your feature request related to a problem or challenge? Please describe what you are trying to do.
Depending on the usecase sometimes one wants the days of week to start from Sunday or Monday. Dates 🤷
@ovr added the
weekday0
kernel in #2052But now the names are
weekday
andweekday0
which I think might be confusing to the average readerDescribe the solution you'd like
I propose we follow the chrono naming scheme
num_days_from_sunday
andnum_days_from_monday
https://docs.rs/chrono/0.4.19/chrono/enum.Weekday.html#method.num_days_from_sunday
https://docs.rs/chrono/0.4.19/chrono/enum.Weekday.html#method.num_days_from_monday
Describe alternatives you've considered
We could do nothing and handle any potential confusion with documentation
Additional context
Add any other context or screenshots about the feature request here.
The text was updated successfully, but these errors were encountered: