Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename DataType::Decimal to DataType::Decimal128 #2228

Closed
viirya opened this issue Jul 29, 2022 · 0 comments · Fixed by #2229
Closed

Rename DataType::Decimal to DataType::Decimal128 #2228

viirya opened this issue Jul 29, 2022 · 0 comments · Fixed by #2229
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog

Comments

@viirya
Copy link
Member

viirya commented Jul 29, 2022

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

To be align with other major Arrow implementations, we should rename Decimal datatype to Decimal128 to be better distinct from 256-bit decimal type.

C++: arrow::Decimal128Type
Python: pyarrow.decimal128

Describe the solution you'd like

Describe alternatives you've considered

Additional context
@viirya viirya added the enhancement Any new improvement worthy of a entry in the changelog label Jul 29, 2022
This was referenced Jul 29, 2022
Merged
Closed
@alamb alamb added the arrow Changes to the arrow crate label Aug 4, 2022
@alamb alamb changed the title Rename DataType::Decimal to DataType::Decimal128 Rename DataType::Decimal to DataType::Decimal128 Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename DataType::Decimal to DataType::Decimal128 viirya/arrow-rs
2 participants
@viirya @alamb