Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure a successful MIRI Run on CI #227

Closed
alamb opened this issue Apr 26, 2021 · 2 comments
Closed

Ensure a successful MIRI Run on CI #227

alamb opened this issue Apr 26, 2021 · 2 comments
Labels

Comments

@alamb
Copy link
Contributor

alamb commented Apr 26, 2021

Note: migrated from original JIRA: https://issues.apache.org/jira/browse/ARROW-11715

Now we have the MIRI check setup to pass even of cargo miri returns an error.

https://github.com/apache/arrow/blob/master/.github/workflows/rust.yml#L263-L264

          # Ignore MIRI errors until we can get a clean run
          cargo miri test || true

Goal is to make MIRI pass and then remove this check in CI

@jhorstmann
Copy link
Contributor

@alamb I think this was fixed by #421 and can be closed

@alamb
Copy link
Contributor Author

alamb commented Jun 21, 2021

Agree -- thanks @jhorstmann !

@alamb alamb closed this as completed Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants