Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arrow-rs contains a copy of the "format" directory #233

Closed
andygrove opened this issue Apr 27, 2021 · 7 comments
Closed

arrow-rs contains a copy of the "format" directory #233

andygrove opened this issue Apr 27, 2021 · 7 comments
Labels
arrow Changes to the arrow crate bug

Comments

@andygrove
Copy link
Member

Describe the bug
This repo contains a copy of the "format" directory, containing flatbuffer definitions. We should instead reference the format directory from the arrow monorepo.

@andygrove andygrove added the bug label Apr 27, 2021
@nevi-me
Copy link
Contributor

nevi-me commented Apr 27, 2021

What would be a good approach to keep a copy of the *fbs files? I wonder if it could make sense to create a repository called arrow-format, so that this can be shared by various repos.

Should I bring this up on the ML?

@jorgecarleitao
Copy link
Member

What would be a good approach to keep a copy of the *fbs files? I wonder if it could make sense to create a repository called arrow-format, so that this can be shared by various repos.

Should I bring this up on the ML?

Ahahah, was about to ping you for help here. :)

AFAIK arrow-flight/build.rs checks for changes on the definitions. So, even as a repo, it requires everyone to clone it, or us to submodule it.

An alternative is to simply remove the build.rs and perform the update manually; the definition does not change so often, anyways.

I agree that a lightweight repo with the specification alone would help.

@nevi-me
Copy link
Contributor

nevi-me commented Apr 27, 2021

I agree that a lightweight repo with the specification alone would help.

I've been out of the loop on the discussions, but from what i've been able to follow, it looks like Julia might also get its own repo, to move development to the apache org.

So I think if the format repo gets treated like the parquet-format as an arrow-format, it could work out well as a lightweight repo.

@nevi-me
Copy link
Contributor

nevi-me commented Apr 27, 2021

I've sent a message to the ML, to ask about this

@elferherrera
Copy link
Contributor

Is it possible to link this "format" folder to the arrow "format" folder?

@alamb alamb added the arrow Changes to the arrow crate label May 3, 2021
@nevi-me
Copy link
Contributor

nevi-me commented May 3, 2021

@andygrove we'll maintain a copy, and sync with the folder in the arrow repo when there are changes.

Can we close this?

@andygrove
Copy link
Member Author

Thanks for the update @nevi-me. Closing this now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate bug
Projects
None yet
Development

No branches or pull requests

5 participants