Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compilation error under chrono-tz feature #2878

Closed
viirya opened this issue Oct 15, 2022 · 1 comment · Fixed by #2879
Closed

Compilation error under chrono-tz feature #2878

viirya opened this issue Oct 15, 2022 · 1 comment · Fixed by #2879
Labels
arrow Changes to the arrow crate bug

Comments

@viirya
Copy link
Member

viirya commented Oct 15, 2022

Describe the bug

When enabling chrono-tz feature, there are compilation error:

error[E0061]: this function takes 0 arguments but 2 arguments were supplied
    --> arrow/src/compute/kernels/cast.rs:5646:21
     |
5646 |         let mut b = PrimitiveDictionaryBuilder::new(keys_builder, values_builder);     
     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ------------  -------------- argument of type `arrow_array::builder::PrimitiveBuilder<arrow_array::types::Int32Type>` unexpected
     |                                                     |                                                                                                                                                                           
     |                                                     argument of type `arrow_array::builder::PrimitiveBuilder<K>` unexpected
     |
note: associated function defined here                                                                             
    --> /Users/liangchi/repos/arrow-rs/arrow-array/src/builder/primitive_dictionary_builder.rs:108:12
     |
108  |     pub fn new() -> Self {                                                                                  
     |            ^^^   
help: remove the extra arguments
     |                                                                                                             
5646 |         let mut b = PrimitiveDictionaryBuilder::new();
     |                                                    ~~                                                
                                                                                                                   
error[E0061]: this function takes 0 arguments but 2 arguments were supplied
    --> arrow/src/compute/kernels/cast.rs:5658:21                                                                  
     |                                                                                                             
5658 |         let mut b = StringDictionaryBuilder::new(keys_builder, values_builder);
     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ------------  -------------- argument of type `arrow_array::builder::GenericStringBuilder<i32>` unexpected
     |                                                  |                                                          
     |                                                  argument of type `arrow_array::builder::PrimitiveBuilder<K>` unexpected
     |  

To Reproduce

Expected behavior

Additional context

@viirya viirya added the bug label Oct 15, 2022
@alamb alamb added the arrow Changes to the arrow crate label Oct 28, 2022
@alamb
Copy link
Contributor

alamb commented Oct 28, 2022

label_issue.py automatically added labels {'arrow'} from #2879

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants