Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add with_escape for csv::ReaderBuilder #315

Closed
kazuk opened this issue May 18, 2021 · 0 comments · Fixed by #326
Closed

add with_escape for csv::ReaderBuilder #315

kazuk opened this issue May 18, 2021 · 0 comments · Fixed by #326
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog

Comments

@kazuk
Copy link
Contributor

kazuk commented May 18, 2021

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

Allow read non-standard CSV.

background: I plan to read external CSV source, that have non-standard escape rule.

Describe the solution you'd like

  • add escape: Option<u8> field to ReaderBuilder.
  • add pub fn with_escape( mut self, escape: u8 ) -> Self method to ReaderBuilder.
  • optional with_quote for quote setting
  • add pub(crate) fn from_builder( builder: ReaderBuilder ) -> Self to Reader
    and handle builder options
  • change pub fn build<R: Read + Seek>(self, mut reader: R) -> Result<Reader<R>> on ReaderBuilder
    call from_builder

Describe alternatives you've considered

add pub fn from_csv_reader( csv_reader: crate_csv::Reader ) ->Self to Reader
use custom builded csv_reader

@kazuk kazuk added the enhancement Any new improvement worthy of a entry in the changelog label May 18, 2021
@alamb alamb added the arrow Changes to the arrow crate label May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants